Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy and un deploy functionality #3073

Conversation

msivasubramaniaan
Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan commented Jul 31, 2023

Related to #3010

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 4.00% and project coverage change: -1.07% ⚠️

Comparison is base (48c7457) 33.77% compared to head (c2d1150) 32.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3073      +/-   ##
==========================================
- Coverage   33.77%   32.71%   -1.07%     
==========================================
  Files          73       74       +1     
  Lines        4755     4934     +179     
  Branches      907      940      +33     
==========================================
+ Hits         1606     1614       +8     
- Misses       3149     3320     +171     
Files Changed Coverage Δ
src/serveressFunction/commands.ts 17.64% <0.00%> (-7.36%) ⬇️
src/serveressFunction/types.ts 100.00% <ø> (ø)
src/serveressFunction/build-run-deploy.ts 4.97% <2.77%> (-0.54%) ⬇️
src/serveressFunction/multiStepInput.ts 3.57% <3.57%> (ø)
src/serveressFunction/view.ts 30.50% <4.54%> (-3.48%) ⬇️
src/serveressFunction/functionImpl.ts 25.33% <10.34%> (-6.75%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datho7561
Copy link
Contributor

I tested deploying onto the sandbox cluster, since I couldn't figure out how to set up Knative serverless on crc.

Here are a few things I ran into:

  • When I run func deploy on the command line it gives information on the progress and at the end it outputs the URL of the function. I didn't see any of this information when using the "Deploy" context menu. Is this intentional? I think it would be nice to display the URL somewhere, either by showing the command output, or having some sort of UI, maybe a button to open/copy the URL.
  • If I have deployed the function, but then make a change to the source code, then I can update the version running on the cluster by rerunning func deploy. It would be nice to keep the deploy option in the context menu, even if the function is currently deployed

@msivasubramaniaan
Copy link
Collaborator Author

I tested deploying onto the sandbox cluster, since I couldn't figure out how to set up Knative serverless on crc.

Here are a few things I ran into:

  • When I run func deploy on the command line it gives information on the progress and at the end it outputs the URL of the function. I didn't see any of this information when using the "Deploy" context menu. Is this intentional? I think it would be nice to display the URL somewhere, either by showing the command output, or having some sort of UI, maybe a button to open/copy the URL.
  • If I have deployed the function, but then make a change to the source code, then I can update the version running on the cluster by rerunning func deploy. It would be nice to keep the deploy option in the context menu, even if the function is currently deployed

@datho7561 addressed the feedback that you provided. Please have a look

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well for me! Thanks, Muthu!

@msivasubramaniaan msivasubramaniaan merged commit b847944 into redhat-developer:main Aug 9, 2023
3 of 5 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 3010-create-ui-for-serverless-deploy-and-invoke-function branch August 9, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants