-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy and un deploy functionality #3073
deploy and un deploy functionality #3073
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
- Coverage 33.77% 32.71% -1.07%
==========================================
Files 73 74 +1
Lines 4755 4934 +179
Branches 907 940 +33
==========================================
+ Hits 1606 1614 +8
- Misses 3149 3320 +171
☔ View full report in Codecov by Sentry. |
I tested deploying onto the sandbox cluster, since I couldn't figure out how to set up Knative serverless on Here are a few things I ran into:
|
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@datho7561 addressed the feedback that you provided. Please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well for me! Thanks, Muthu!
Related to #3010