Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Create Component From Folder action to workspace folder #3085

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Add Create Component From Folder action to workspace folder #3085

merged 1 commit into from
Aug 10, 2023

Conversation

JessicaJHee
Copy link
Member

@JessicaJHee JessicaJHee commented Aug 4, 2023 •
edited
Loading

Fixes #3039

createComponentFromWorkspaceFolder

@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Patch coverage: 9.09% and project coverage change: -0.07% ⚠️

Comparison is base (eefc962) 32.71% compared to head (150d000) 32.64%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
- Coverage   32.71%   32.64%   -0.07%     
==========================================
  Files          74       74              
  Lines        4934     4944      +10     
  Branches      940      940              
==========================================
  Hits         1614     1614              
- Misses       3320     3330      +10
Files Changed Coverage Δ
.../webview/create-component/createComponentLoader.ts 11.88% <0.00%> (-0.15%) ⬇️
src/openshift/component.ts 18.56% <14.28%> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaJHee JessicaJHee marked this pull request as draft August 4, 2023 19:36
@JessicaJHee JessicaJHee force-pushed the 3039-deploy-to-os branch 4 times, most recently from 2766268 to 19ceffa Compare August 9, 2023 13:52
@JessicaJHee JessicaJHee marked this pull request as ready for review August 9, 2023 14:05
@JessicaJHee JessicaJHee changed the title Add Deploy to Openshift/Podman action to workspace folder Add Create Component From Folder action to workspace folder Aug 9, 2023
datho7561
datho7561 requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, but it appears to be working pretty well.

src/webview/create-component/createComponentLoader.ts Outdated Show resolved Hide resolved
src/webview/create-component/pages/createComponent.tsx Outdated Show resolved Hide resolved
src/webview/create-component/pages/createComponent.tsx Outdated Show resolved Hide resolved
@JessicaJHee JessicaJHee force-pushed the 3039-deploy-to-os branch 2 times, most recently from adac154 to c0ad9be Compare August 10, 2023 13:44
datho7561
datho7561 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, Jessica!

@datho7561 datho7561 merged commit 8e0cff8 into redhat-developer:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Deploy to OpenShift/Podman action to folder in workspace
2 participants
@JessicaJHee @datho7561