-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Jenkins release build to GitHub Actions. #3089
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3089 +/- ##
==========================================
- Coverage 33.77% 32.71% -1.07%
==========================================
Files 73 74 +1
Lines 4755 4934 +179
Branches 907 940 +33
==========================================
+ Hits 1606 1614 +8
- Misses 3149 3320 +171 ☔ View full report in Codecov by Sentry. |
@rgrunber so once we start the action, it will ask for approval to publish to Marketplace, is that a notification based or we have to manually go in the action logs and approve it ? |
I didn't see anything in GH notifications but I did get an email with this : |
f95355a
to
0362e56
Compare
The unit test suite ( This integration test suite is flaky, but we're working on fixing it:
These integration test suites require an OpenShift cluster to run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a step we can probably skip, but other than that it seems good.
0362e56
to
0c4e100
Compare
0c4e100
to
0c068aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
0c068aa
to
48ed2a8
Compare
Fixes Migrate Jenkins build to GH Actions for release #3059
See https://github.com/rgrunber/vscode-openshift-tools/actions/runs/5804080228 for a sample of the build. It publishes a draft release at https://github.com/rgrunber/vscode-openshift-tools/releases/tag/1.6.0 (with the vsix artifacts included so they can be tested prior to approval) in addition to tagging the release.
Is it worth adding the smoke tests ? They seem to be failing now.
I have simplified some of the packaging logic, but it should behave the same, just less duplication of lines
The
TARGET=all
was used to create a universal vsix that contained all of the tooling (and was also used in the smoke tests although maybe we could just use linux-x64 vsix for the smoke tests on ubuntu-latest). It was very large, and only used on OpenVSX. We removed it in Publish platform-specific VSIXs for OpenVSX. #2908. So we have no real reason to package it since we don't publish it anywhere.We aren't using pre-releases but I kept that input option in for potential future use.