Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Jenkins release build to GitHub Actions. #3089

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Aug 9, 2023

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.07% ⚠️

Comparison is base (7dccf83) 33.77% compared to head (48ed2a8) 32.71%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3089      +/-   ##
==========================================
- Coverage   33.77%   32.71%   -1.07%     
==========================================
  Files          73       74       +1     
  Lines        4755     4934     +179     
  Branches      907      940      +33     
==========================================
+ Hits         1606     1614       +8     
- Misses       3149     3320     +171     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohitsuman
Copy link
Collaborator

@rgrunber so once we start the action, it will ask for approval to publish to Marketplace, is that a notification based or we have to manually go in the action logs and approve it ?

@rgrunber
Copy link
Member Author

rgrunber commented Aug 9, 2023

@rgrunber so once we start the action, it will ask for approval to publish to Marketplace, is that a notification based or we have to manually go in the action logs and approve it ?

I didn't see anything in GH notifications but I did get an email with this :

image

@datho7561
Copy link
Contributor

The unit test suite (npm run test) passes consistently. I think we can run it as a part of the release build.

This integration test suite is flaky, but we're working on fixing it:

  • npm run public-ui-test

These integration test suites require an OpenShift cluster to run:

  • npm run cluster-ui-test
  • npm run test-integration

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a step we can probably skip, but other than that it seems good.

.github/workflows/release.yml Outdated Show resolved Hide resolved
datho7561
datho7561 previously approved these changes Aug 9, 2023
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber merged commit eefc962 into redhat-developer:main Aug 10, 2023
4 of 5 checks passed
@rgrunber rgrunber deleted the migrate-to-gha branch August 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Jenkins build to GH Actions for release
3 participants