Handle importing git repos that already have a Devfile #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes redhat-developer#3104 Signed-off-by: David Thompson <davthomp@redhat.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
- Coverage 32.82% 32.80% -0.02%
==========================================
Files 74 74
Lines 4960 4962 +2
Branches 944 945 +1
==========================================
Hits 1628 1628
- Misses 3332 3334 +2
☔ View full report in Codecov by Sentry. |
|
@vrubezhny If you have time at some point, could you please review this PR? Let me know if you have any questions about it. Hopefully the video in the issue explains the use case well enough. |
rgrunber
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3104
Signed-off-by: David Thompson davthomp@redhat.com