Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement manage repositories workflow in serverless view #3126

Conversation

msivasubramaniaan
Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan commented Aug 25, 2023

Fixes: #3055

manage-repo

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 13.41% and project coverage change: -0.54% ⚠️

Comparison is base (1c86edb) 32.01% compared to head (2443ebb) 31.47%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3126      +/-   ##
==========================================
- Coverage   32.01%   31.47%   -0.54%     
==========================================
  Files          74       75       +1     
  Lines        5120     5252     +132     
  Branches      973      996      +23     
==========================================
+ Hits         1639     1653      +14     
- Misses       3481     3599     +118     
Files Changed Coverage Δ
src/serverlessFunction/commands.ts 7.40% <0.00%> (-1.97%) ⬇️
src/serverlessFunction/manageRepository.ts 10.41% <10.41%> (ø)
...erless-manage-repository/manageRepositoryLoader.ts 12.69% <12.69%> (ø)
.../webview/create-component/createComponentLoader.ts 11.20% <20.00%> (-0.68%) ⬇️
src/webview/common-ext/utils.ts 47.50% <22.72%> (-30.28%) ⬇️
src/serverlessFunction/view.ts 33.57% <66.66%> (+0.72%) ⬆️
...ew/serverless-function/serverlessFunctionLoader.ts 14.45% <100.00%> (-1.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohitsuman
Copy link
Collaborator

@msivasubramaniaan have we added the telemetry events for all the actions for Manage Repository ? From Adding to updation.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
Copy link
Collaborator Author

@msivasubramaniaan have we added the telemetry events for all the actions for Manage Repository ? From Adding to updation.

Yes, The command based calls were captured as per the framework. The other events are captured with latest commit.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
Copy link
Collaborator

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording and UI improvement recommendation.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
.eslintignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/serverlessFunction/mangeRepository.ts Outdated Show resolved Hide resolved
src/serverlessFunction/mangeRepository.ts Outdated Show resolved Hide resolved
src/webview/manage-repository/manageRepositoryLoader.ts Outdated Show resolved Hide resolved
src/webview/manage-repository/app/home.tsx Outdated Show resolved Hide resolved
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning on incorporating Mohit's suggestion of hiding the action buttons for the default repository? Otherwise, looks good!

@msivasubramaniaan
Copy link
Collaborator Author

Are you planning on incorporating Mohit's suggestion of hiding the action buttons for the default repository? Otherwise, looks good!

At the end he mentioned it was okay. @mohitsuman if it not an issue please provide +1

Copy link
Collaborator

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mohitsuman mohitsuman changed the title 3055 implement manage repositories workflow in serverless view Implement manage repositories workflow in serverless view Aug 31, 2023
@mohitsuman mohitsuman merged commit 843dca5 into redhat-developer:main Aug 31, 2023
3 of 5 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 3055-implement-manage-repositories-workflow-in-serverless-view branch September 7, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Manage Repositories workflow in serverless view
3 participants