-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement manage repositories workflow in serverless view #3126
Implement manage repositories workflow in serverless view #3126
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
…in-serverless-view
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3126 +/- ##
==========================================
- Coverage 32.01% 31.47% -0.54%
==========================================
Files 74 75 +1
Lines 5120 5252 +132
Branches 973 996 +23
==========================================
+ Hits 1639 1653 +14
- Misses 3481 3599 +118
☔ View full report in Codecov by Sentry. |
@msivasubramaniaan have we added the telemetry events for all the actions for Manage Repository ? From Adding to updation. |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Yes, The command based calls were captured as per the framework. The other events are captured with latest commit. |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Co-authored-by: Mohit Suman <mohit.skn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording and UI improvement recommendation.
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
src/webview/serverless-manage-repository/app/showRepositories.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning on incorporating Mohit's suggestion of hiding the action buttons for the default repository? Otherwise, looks good!
At the end he mentioned it was okay. @mohitsuman if it not an issue please provide +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes: #3055