Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show card if existing Devfile is used #3130

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

datho7561
Copy link
Contributor

Instead, show an information message indicating that the existing devfile will be used.

Fixes #3129

Signed-off-by: David Thompson davthomp@redhat.com

Instead, show an information message indicating that the existing
devfile will be used.

Fixes redhat-developer#3129

Signed-off-by: David Thompson <davthomp@redhat.com>
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@datho7561
Copy link
Contributor Author

Thanks for the review!

@datho7561 datho7561 merged commit bc5ad30 into redhat-developer:main Aug 28, 2023
3 checks passed
@datho7561 datho7561 deleted the 3129-dont-show-card branch August 28, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If an existing devfile is used, don't show the card with the recommended devfile
2 participants