Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Fix File Watcher Utility test - close FileWatcher #3148

Conversation

vrubezhny
Copy link
Contributor

Also, avoided to watch the whole temp directory because of its possibly very big size in order to not get 'too many open files error

Also, avoided to watch the whole temp directory because of its
possibly very big size in order to not get 'too many open files error

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9607622) 33.53% compared to head (17a0b90) 33.53%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3148   +/-   ##
=======================================
  Coverage   33.53%   33.53%           
=======================================
  Files          74       74           
  Lines        5114     5114           
  Branches      974      974           
=======================================
  Hits         1715     1715           
  Misses       3399     3399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Victor!

@datho7561 datho7561 added this to the 1.7.0 milestone Aug 31, 2023
@datho7561 datho7561 merged commit 51ac8f4 into redhat-developer:main Aug 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants