Fix sandbox stuck loading #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't `await` message being sent to the webview when the webview is being built, since the webview is likely unable to receive the message yet. Fixes redhat-developer#3323 Signed-off-by: David Thompson <davthomp@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3325 +/- ##
==========================================
- Coverage 37.04% 37.00% -0.05%
==========================================
Files 77 77
Lines 5356 5362 +6
Branches 1032 1032
==========================================
Hits 1984 1984
- Misses 3372 3378 +6
☔ View full report in Codecov by Sentry. |
msivasubramaniaan
merged commit f201109
into
redhat-developer:main
4 of 6 checks passed
|
Thanks @datho7561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't
awaitmessage being sent to the webview when the webview is being built, since the webview is likely unable to receive the message yet.Fixes #3323
Signed-off-by: David Thompson davthomp@redhat.com