Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to binary file for component creation #347

Merged
merged 6 commits into from
Nov 30, 2018

Conversation

mohitsuman
Copy link
Collaborator

Fix #223

@codecov
Copy link

codecov bot commented Nov 17, 2018

Codecov Report

Merging #347 into master will increase coverage by 0.52%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   61.31%   61.83%   +0.52%     
==========================================
  Files          20       20              
  Lines         853      870      +17     
  Branches      134      140       +6     
==========================================
+ Hits          523      538      +15     
- Misses        330      332       +2
Impacted Files Coverage Δ
src/openshift/component.ts 80.46% <90.47%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9124b...9c60d39. Read the comment docs.

@mohitsuman
Copy link
Collaborator Author

testPR

Copy link
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should be fixed first.

@mohitsuman
Copy link
Collaborator Author

testPR

1 similar comment
@mohitsuman
Copy link
Collaborator Author

testPR

@mohitsuman
Copy link
Collaborator Author

@dgolovin Please review.

@dgolovin dgolovin merged commit 9697f83 into redhat-developer:master Nov 30, 2018
@dgolovin dgolovin removed the review label Nov 30, 2018
@mohitsuman mohitsuman deleted the gh-223-fix branch June 16, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants