-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "OK" and "Cancel" buttons to cluster login quick picks input fields #3475
Add "OK" and "Cancel" buttons to cluster login quick picks input fields #3475
Conversation
328466f
to
0a88a2b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
- Coverage 35.68% 35.43% -0.25%
==========================================
Files 79 79
Lines 5571 5613 +42
Branches 1096 1116 +20
==========================================
+ Hits 1988 1989 +1
- Misses 3583 3624 +41
☔ View full report in Codecov by Sentry. |
If I try to add a new user, it errors and I get "Excpected a string but got an undefined" |
ea9a850
to
a8d6262
Compare
a8d6262
to
a0d55f4
Compare
No need to use keyboard if you already have your credentials saved: Screencast.from.2023-10-25.18-30-22.webmYou can go back from any step of login workflow: Screencast.from.2023-10-25.19-28-49.webm |
@datho7561 Fixed this as well as few other issues I found (returning back from login method selection) |
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
a0d55f4
to
fdd915b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working well. Thank you, Victor!
This PR adds a possibility to finish or cancel an entering value operation (like, for new cluster URL, new username, password, token inputs) with pressing an
Enter
orCancel
clickable buttons: