Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "OK" and "Cancel" buttons to cluster login quick picks input fields #3475

Conversation

vrubezhny
Copy link
Contributor

This PR adds a possibility to finish or cancel an entering value operation (like, for new cluster URL, new username, password, token inputs) with pressing an Enter or Cancel clickable buttons:

image

@vrubezhny vrubezhny requested a review from datho7561 October 20, 2023 17:46
@vrubezhny vrubezhny force-pushed the fix-fix-cluster-login-quick-pick-add-ok-cancel-buppons branch from 328466f to 0a88a2b Compare October 20, 2023 18:12
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (d7cedf2) 35.68% compared to head (fdd915b) 35.43%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3475      +/-   ##
==========================================
- Coverage   35.68%   35.43%   -0.25%     
==========================================
  Files          79       79              
  Lines        5571     5613      +42     
  Branches     1096     1116      +20     
==========================================
+ Hits         1988     1989       +1     
- Misses       3583     3624      +41     
Files Coverage Δ
src/openshift/cluster.ts 8.20% <0.00%> (-0.29%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datho7561
Copy link
Contributor

If I try to add a new user, it errors and I get "Excpected a string but got an undefined"

@vrubezhny vrubezhny self-assigned this Oct 24, 2023
@vrubezhny vrubezhny marked this pull request as draft October 24, 2023 16:26
@vrubezhny vrubezhny force-pushed the fix-fix-cluster-login-quick-pick-add-ok-cancel-buppons branch 2 times, most recently from ea9a850 to a8d6262 Compare October 25, 2023 16:02
@vrubezhny vrubezhny marked this pull request as ready for review October 25, 2023 16:31
@vrubezhny vrubezhny force-pushed the fix-fix-cluster-login-quick-pick-add-ok-cancel-buppons branch from a8d6262 to a0d55f4 Compare October 25, 2023 17:31
@vrubezhny
Copy link
Contributor Author

No need to use keyboard if you already have your credentials saved:

Screencast.from.2023-10-25.18-30-22.webm

You can go back from any step of login workflow:

Screencast.from.2023-10-25.19-28-49.webm

@vrubezhny
Copy link
Contributor Author

If I try to add a new user, it errors and I get "Excpected a string but got an undefined"

@datho7561 Fixed this as well as few other issues I found (returning back from login method selection)

@vrubezhny vrubezhny marked this pull request as draft October 25, 2023 17:56
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny force-pushed the fix-fix-cluster-login-quick-pick-add-ok-cancel-buppons branch from a0d55f4 to fdd915b Compare October 25, 2023 18:38
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well. Thank you, Victor!

@vrubezhny vrubezhny marked this pull request as ready for review October 25, 2023 18:56
@datho7561 datho7561 added this to the 1.10.0 milestone Oct 25, 2023
@datho7561 datho7561 added the kind/enhancement New feature or request label Oct 25, 2023
@datho7561 datho7561 merged commit f11efa8 into redhat-developer:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants