-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OK/Cancel buttons to the text input fields #3521
Add OK/Cancel buttons to the text input fields #3521
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
==========================================
- Coverage 34.49% 34.23% -0.26%
==========================================
Files 81 82 +1
Lines 5787 5847 +60
Branches 1158 1171 +13
==========================================
+ Hits 1996 2002 +6
- Misses 3791 3845 +54
☔ View full report in Codecov by Sentry. |
08c108f
to
e316f5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very well from my testing.
One thing I ran into is that the back button doesn't work as expected in the "Add Devfile Registry" workflow. I think it would be helpful to have the back button working. Do you want to work on that in this PR, or should I file this as an issue to work on in the future?
Thanks for looking at this. I think you're right, and |
e316f5c
to
7ed9acc
Compare
Added the possibility to go back when creating a Devfile Registry item: Screencast.from.2023-11-06.18-22-33.webm |
If I enter an invalid URL (eg. |
I can't reproduce any kind of freeze here. But yes, there is a bug: if input is not valid it just closes the input URL dialog leaving the promise not resolved, so it might freeze later on repeated retries. UPD: The problem is an exception happening in UPD 2: Fixed now |
3aa6fe5
to
0785f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to working well. Thanks, Victor!
This PR adds OK/Cancel buttons to the text input fields used at the creation of a cluster namespace/project as well as at the adding of a Devfile Registry (name, URL, token) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
0785f32
to
237970c
Compare
This PR adds OK/Cancel buttons to the text input fields used at the creation of a cluster namespace/project as well as at the adding of a Devfile Registry (name, URL, token)