-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvements on dev file registry web view #3629
UI improvements on dev file registry web view #3629
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3629 +/- ##
==========================================
- Coverage 33.41% 33.19% -0.23%
==========================================
Files 84 84
Lines 6096 6140 +44
Branches 1239 1254 +15
==========================================
+ Hits 2037 2038 +1
- Misses 4059 4102 +43 ☔ View full report in Codecov by Sentry. |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
…/msivasubramaniaan/vscode-openshift-tools into devfile-registry-ui-improvements
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Just an opinion... I can't really say that I'm happy with the view layout...
The previous layout was more or less consistent with this scheme, while the new one puts the keyword filter on top - like it's the most important thing, at the same time hiding the Devfile registry selection underneath and keeping the same space for the Devfile list (in my case its size is even reduced a bit)... Personally I think that previous layout was looking better, the only thing I would change is that big header with a lot of empty space and title: I'd remove it giving more space to the Devfile list (again, I see the only 1.5-2 lines in the list which is really no good. Ideally if we can show all 6 items reserved to be on each page.. I know this is almost impossible, given the size of description text for each item and text size (which should be clearly visible), but still the more items we show here - the better). IMHO |
I like the direction of this PR. Removing the title to better use the space is a great idea. There are a few changes that I think would be nice, though:
|
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
All the views should e consistent, so we should be removing the gap. The idea is to utilise the real estate in the layout.
@msivasubramaniaan is the screenshot in the description latest of the UX changes ?
+1 to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few Changes in the layout:
- Make search bar height smaller and placeholder inside it at center
- Pagination items at the center of search bar alignment
- Move Tags to the right and reduce logo size, to adjust more entries in the layout.
- Show the Tags Filter in same order as we show The registries
- Adjust the devfile yaml theme based on VSCode Light and Dark Theme
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
|
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
(from Victor) I missed this the first time I reviewed the PR, but I also agree that the Devfile Registry checkboxes should appear above the Tag checkboxes |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@datho7561 and @vrubezhny Thanks for the review. I just fixed the issue identified by @vrubezhny please take a look. @mohitsuman FYI I moved the dev file registry selection on top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that we can show more Devfiles in one page and I like the change to support light themes for the YAML viewer. I'm not enthusiastic about most of the other changes. It seems to work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
still cannot merge? |
@msivasubramaniaan please share the latest UI look and also the UI for devfile yaml in both light and dark theme. |
@mohitsuman FYR, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes: #3636