Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'FINDSTR' when windows machine instead of grep #3715

Merged

Conversation

msivasubramaniaan
Copy link
Collaborator

Problem:

const result = await CliChannel.getInstance().executeTool(new CommandText('oc api-resources | grep openshift'));
always fails in windows machine wrt 'grep' command.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e489f5) 33.24% compared to head (12af72f) 33.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3715      +/-   ##
==========================================
+ Coverage   33.24%   33.26%   +0.02%     
==========================================
  Files          84       84              
  Lines        6136     6138       +2     
  Branches     1253     1254       +1     
==========================================
+ Hits         2040     2042       +2     
  Misses       4096     4096              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny
Copy link
Contributor

This probably is related to #3493 - I can't reproduce this on Linux, but it definitely could be a reason of the issue on Windows side. So this PR could probably fix #3493

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Without this change, I can't see the link to open the OpenShift Dashboard, but with it I can.

@datho7561 datho7561 merged commit 9efcd13 into redhat-developer:main Dec 11, 2023
6 checks passed
@msivasubramaniaan msivasubramaniaan deleted the fix-grep-command-in-windows branch December 11, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants