-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy container image to cluster #3798
Deploy container image to cluster #3798
Conversation
@mohitsuman when you have a change, could you please tell me what do you think about this workflow? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3798 +/- ##
==========================================
- Coverage 33.12% 32.81% -0.31%
==========================================
Files 84 85 +1
Lines 6195 6311 +116
Branches 1270 1287 +17
==========================================
+ Hits 2052 2071 +19
- Misses 4143 4240 +97 ☔ View full report in Codecov by Sentry. |
baa68eb
to
0ae4c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works good,
Please take into account the suggestions listed inline
- Add "Create Deployment from Container Image URL" wizard to project context menu - It uses the VS Code text input - It has a back button and remembers what you've entered when you go back, similar to what Victor did for the login workflow - Once the deployment's been created, the logs for the container are opened in the OpenShift Terminal - Add demo gif and walkthrough entry for "Create Deployment from Container Image URL" - Add "Delete" context menu item for Kubernetes objects (eg. Deployments) - Add "Watch logs" context menu item for Kubernetes objects (eg. Deployments) Closes redhat-developer#2418 Signed-off-by: David Thompson <davthomp@redhat.com>
0ae4c62
to
beb234f
Compare
Some more things to take a look at: After I deleted the container image I've deployed earlier to my Kind cluster and [updating/rebasing/rebuilding] restarting the OS Tools I see the following error message: PS: Probably that's because I've left |
I looked into how Kubernetes handles specifying which ports to expose to the network internal to the cluster. Roland seemed to think this is done as a part of the Docker/OCI image creation (i.e. adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Closes #2418
Signed-off-by: David Thompson davthomp@redhat.com