Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop trying to connect to a cluster when it doesn't appear to be avai… #3848

Conversation

vrubezhny
Copy link
Contributor

…lable

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a7474f0) 32.58% compared to head (f185cbb) 32.58%.

Files Patch % Lines
src/openshift/cluster.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3848      +/-   ##
==========================================
- Coverage   32.58%   32.58%   -0.01%     
==========================================
  Files          85       85              
  Lines        6441     6442       +1     
  Branches     1337     1337              
==========================================
  Hits         2099     2099              
- Misses       4342     4343       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny force-pushed the fix-stop-polling-cluster-on-login-when-cluster-isnt-available branch from 5180b70 to 01b42c5 Compare January 29, 2024 15:55
@vrubezhny vrubezhny requested a review from datho7561 January 29, 2024 17:21
@datho7561
Copy link
Contributor

datho7561 commented Jan 29, 2024

We should do something similar for crc here:

https://github.com/redhat-developer/vscode-openshift-tools/pull/3848/files#diff-4c0f5d259edd0b2da811850fbc4f92c43ba5ee7d2f162594588bdaeb363050ebR536

Otherwise you will face the same problem of infinite loop (eg. when you dismiss the notification, it appears again)

(also for sandbox)

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for clusters that aren't crc or sandbox, but the same fix needs to be applied for crc and sandbox.

@vrubezhny vrubezhny force-pushed the fix-stop-polling-cluster-on-login-when-cluster-isnt-available branch from 01b42c5 to be59cc3 Compare January 30, 2024 03:25
@vrubezhny vrubezhny requested a review from datho7561 January 30, 2024 03:58
@vrubezhny
Copy link
Contributor Author

This works for clusters that aren't crc or sandbox, but the same fix needs to be applied for crc and sandbox.

Agree, please review the fixup

@vrubezhny vrubezhny force-pushed the fix-stop-polling-cluster-on-login-when-cluster-isnt-available branch from be59cc3 to 5791175 Compare January 30, 2024 04:08
…lable

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny force-pushed the fix-stop-polling-cluster-on-login-when-cluster-isnt-available branch from 5791175 to f185cbb Compare January 30, 2024 04:20
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me. Thanks, Victor!

@datho7561 datho7561 added this to the 1.12.0 milestone Jan 30, 2024
@datho7561 datho7561 merged commit 4928429 into redhat-developer:main Jan 30, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants