-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop trying to connect to a cluster when it doesn't appear to be avai… #3848
Stop trying to connect to a cluster when it doesn't appear to be avai… #3848
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3848 +/- ##
==========================================
- Coverage 32.58% 32.58% -0.01%
==========================================
Files 85 85
Lines 6441 6442 +1
Branches 1337 1337
==========================================
Hits 2099 2099
- Misses 4342 4343 +1 ☔ View full report in Codecov by Sentry. |
5180b70
to
01b42c5
Compare
We should do something similar for crc here: Otherwise you will face the same problem of infinite loop (eg. when you dismiss the notification, it appears again) (also for sandbox) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for clusters that aren't crc
or sandbox, but the same fix needs to be applied for crc
and sandbox.
01b42c5
to
be59cc3
Compare
Agree, please review the fixup |
be59cc3
to
5791175
Compare
…lable Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
5791175
to
f185cbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works for me. Thanks, Victor!
…lable