-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show error message if docker is not running #3854
show error message if docker is not running #3854
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3854 +/- ##
===========================================
+ Coverage 32.37% 45.32% +12.95%
===========================================
Files 85 85
Lines 6505 6526 +21
Branches 1349 1349
===========================================
+ Hits 2106 2958 +852
+ Misses 4399 3568 -831 ☔ View full report in Codecov by Sentry. |
@msivasubramaniaan If [on Fedora 38] I have docker installed, but disabled, I see:
... but
|
Please let me know the response of |
Some logs before I execute
... then
maybe the problem is that my user has no rights to operate docker, so I have to execute it with the help of |
I don't have docker installed (just |
@datho7561 May I know which image you are using for build? Isn't it docker.io? |
I'm not 100% sure, but having:
I think at least |
Right! I forgot that you need to build the serverless function before you can run it. I'll double check if I can run the serverless function without podman or docker installed.
You can run container images from docker.io with |
Yes. This PR should works on all the clients like docker desktop, podman, ... |
Okay, you need either docker or podman installed to run "Build" or "Run" |
This line won't work if only |
Maybe
So when docker daemon is stopped (and even disabled) it gets started automatically when I run Given this fact I don't know how can I locally test the appearance of |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
…ker-is-not-started-for-fn-commands
@datho7561 Here is the demo about how this PR works on |
@vrubezhny I am not sure but you can try |
I tried it again, and it still doesn't work with only podman installed. If you uninstall docker, then it won't work. On this line: https://github.com/redhat-developer/vscode-openshift-tools/pull/3854/files#diff-f9b7ce8b2e1d73c6d56dbcb8003e652267411f5c89e851753523d568b575fc48R379 you use the docker binary to check if docker is running. I don't have the docker binary installed on my computer, so no matter what, I am always warned that docker isn't installed. I could symlink |
@msivasubramaniaan This is what I get printed out to the
On the same time docker-services statuses are:
...and
... and the error output ( |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
…ker-is-not-started-for-fn-commands
Looks like now the check works if docker is installed, but not running: Still the question is: if I have
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Still doesn't work for me |
@datho7561 Are you able to stop the docker daemon on your machine? May I Know the response of |
(docker isn't installed) Here is the podman info:
Since docker isn't installed, the docker daemon isn't running. This is the info for the podman systemd service, but I think it works a bit differently from docker:
|
Can you please stop the container |
There are no running containers. There are three stopped containers. I'll try deleting them, I don't think this will fix detection of podman though. It seems Dockerode tries to communicate with podman using |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@datho7561 added a case for check on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works for me. Thank you Muthu! Sorry about the long review process.
no worries @datho7561. It always good to cover all the scenario. Thanks for your review |
Fixes: #3638