There is no any progress indication on Login/Switch context/Change pr…

[vrubezhny]

…oject #3849

Fixes: #3849

[codecov]

Codecov Report

Attention: Patch coverage is 23.52941% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 44.82%. Comparing base (da60441) to head (4076940).
Report is 110 commits behind head on main.

Files	Patch %	Lines
src/openshift/cluster.ts	23.52%	65 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3855       +/-   ##
===========================================
+ Coverage   32.37%   44.82%   +12.44%     
===========================================
  Files          85       85               
  Lines        6505     6742      +237     
  Branches     1349     1406       +57     
===========================================
+ Hits         2106     3022      +916     
+ Misses       4399     3720      -679     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vrubezhny]

A short demo of how the login/logout/switch context operations are notified in Status Bar:

Screencast.from.2024-03-15.18-43-46.webm

[datho7561]

If I close the login wizard after I have input the username, then the status bar "Logging in..." remains on the status bar

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 32.03125% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 45.03%. Comparing base (da60441) to head (e055d82).
Report is 177 commits behind head on main.

Files	Patch %	Lines
src/openshift/cluster.ts	30.57%	84 Missing ⚠️
src/util/inputValue.ts	50.00%	2 Missing ⚠️
src/oc/ocWrapper.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3855       +/-   ##
===========================================
+ Coverage   32.37%   45.03%   +12.65%     
===========================================
  Files          85       85               
  Lines        6505     6804      +299     
  Branches     1349     1428       +79     
===========================================
+ Hits         2106     3064      +958     
+ Misses       4399     3740      -659     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vrubezhny]

If I close the login wizard after I have input the username, then the status bar "Logging in..." remains on the status bar

@datho7561 Could you please re-test your scenario using the updated PR? I can't reproduce the issue.

Also, please look at the comment regarding the use of Node's fetch here: #3855 (comment)

[datho7561]

If I close the login wizard after I have input the username, then the status bar "Logging in..." remains on the status bar

I can still reproduce the bug if I close the wizard by pressing the Escape key, but if it's hard to get that case to work, I think the current behaviour is good.

[datho7561]

Found a typo in the documentation. If you want to fix it, go ahead, but I think it's good to merge as is.

[vrubezhny]

If I close the login wizard after I have input the username, then the status bar "Logging in..." remains on the status bar

I can still reproduce the bug if I close the wizard by pressing the Escape key, but if it's hard to get that case to work, I think the current behaviour is good.

Thanks. Now I can reproduce the issue - it really leaves the notification displayed if I press ESC in username selection quick pick

[vrubezhny]

If I close the login wizard after I have input the username, then the status bar "Logging in..." remains on the status bar

I can still reproduce the bug if I close the wizard by pressing the Escape key, but if it's hard to get that case to work, I think the current behaviour is good.

Should be fixed now

[vrubezhny]

The latest screencast of login/logout/switch contexts and repeated login while the previous login operation isn't finished (cancelling the previous operation):

Screencast.from.2024-04-23.14-51-47.webm