Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Action labels for kubernetes clusters #3918 #3936

Merged

Conversation

vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented Feb 26, 2024

Fixes: #3918

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 56.60377% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 45.23%. Comparing base (da60441) to head (b5ae7bf).
Report is 84 commits behind head on main.

Files Patch % Lines
src/openshift/project.ts 33.33% 14 Missing ⚠️
src/serverlessFunction/functions.ts 20.00% 4 Missing ⚠️
src/explorer.ts 40.00% 3 Missing ⚠️
src/extension.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3936       +/-   ##
===========================================
+ Coverage   32.37%   45.23%   +12.85%     
===========================================
  Files          85       85               
  Lines        6505     6661      +156     
  Branches     1349     1382       +33     
===========================================
+ Hits         2106     3013      +907     
+ Misses       4399     3648      -751     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny marked this pull request as ready for review February 26, 2024 17:15
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change, but otherwise seems great!

package.json Show resolved Hide resolved
Fixes: redhat-developer#3918

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny force-pushed the fixActionLabelsForK8sClusters branch from 6f5e802 to b5ae7bf Compare March 4, 2024 22:23
@vrubezhny vrubezhny requested a review from datho7561 March 4, 2024 22:43
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works like a charm. Thanks, Victor!

@datho7561 datho7561 merged commit 2afe32b into redhat-developer:main Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Action labels for kubernetes clusters
2 participants