'OpenShift: New Service' command to command palette #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 86.85% 86.87% +0.02%
==========================================
Files 20 20
Lines 981 983 +2
Branches 158 159 +1
==========================================
+ Hits 852 854 +2
Misses 129 129
Continue to review full report at Codecov.
|
dgolovin
requested changes
Nov 28, 2018
|
@dgolovin please review this pr |
jrichter1
requested changes
Jan 7, 2019
src/openshift/service.ts
Outdated
| return null; | ||
| } | ||
|
|
||
| static async getApplicationData(application) { |
There was a problem hiding this comment.
Please see #432 (comment) and #499 for the summary of my issues with this implementation.
sudhirverma
force-pushed
the
service
branch
2 times, most recently
from
139dfb0
to
db9264d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #318.