Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rearranged the explorer view #4028

Merged

Conversation

msivasubramaniaan
Copy link
Collaborator

image

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@datho7561
Copy link
Contributor

I don't understand how different resource types are being grouped together here. Deployments are a type of workload (see https://kubernetes.io/docs/concepts/workloads/controllers/).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 44.89%. Comparing base (da60441) to head (4d91cf6).
Report is 136 commits behind head on main.

Files Patch % Lines
src/explorer.ts 38.88% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4028       +/-   ##
===========================================
+ Coverage   32.37%   44.89%   +12.51%     
===========================================
  Files          85       85               
  Lines        6505     6716      +211     
  Branches     1349     1403       +54     
===========================================
+ Hits         2106     3015      +909     
+ Misses       4399     3701      -698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohitsuman
Copy link
Collaborator

I don't understand how different resource types are being grouped together here. Deployments are a type of workload (see https://kubernetes.io/docs/concepts/workloads/controllers/).

We can separate deployment as an individual tree as we want OpenShift devs to focus more on that. All other controllers can go inside the Workload tree, so that the view is clean.

@mohitsuman
Copy link
Collaborator

@datho7561 can you please review this and merge once approved ?

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@datho7561 datho7561 merged commit c3936a6 into redhat-developer:main Apr 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants