Stop downloading odo/oc when cluster is down #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 69.87% 69.72% -0.15%
==========================================
Files 20 20
Lines 853 849 -4
Branches 135 133 -2
==========================================
- Hits 596 592 -4
Misses 257 257
Continue to review full report at Codecov.
|
jrichter1
reviewed
Nov 27, 2018
src/util/progress.ts
Outdated
| progress.report({ | ||
| increment: previous.increment, | ||
| message: `${previous.total}%` | ||
| }); | ||
| }) : result; | ||
|
|
||
| const result: CliExitData = await odo.execute(current.command); |
There was a problem hiding this comment.
If an error happens here, it gets swallowed and the progress is stalled. You might need to call this with fail = false to pass it into the handling below.
mohitsuman
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #386.