-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stdout maxBuffer length to be configurable #4061
Make stdout maxBuffer length to be configurable #4061
Conversation
9c076a9
to
005e31a
Compare
The default value is set to 4Gb. Fixes: redhat-developer#3925 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
005e31a
to
7570b24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4061 +/- ##
===========================================
+ Coverage 32.37% 45.04% +12.66%
===========================================
Files 85 85
Lines 6505 6720 +215
Branches 1349 1404 +55
===========================================
+ Hits 2106 3027 +921
+ Misses 4399 3693 -706 ☔ View full report in Codecov by Sentry. |
With this change, I am able to open the "Pods" and "Deployments" sections if I create 100 deployments. I am going to stress test 400 to see what happens. |
The number of pods really matters: the error ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 MB allows for viewing over 400 deployments, this should (hopefully) be plenty
I used #!/usr/bin/lua
for i = 1, 400, 1 do
os.execute(string.format('oc create deployment --image quay.io/davthomp/pet-alpine my-pet-deploy%d', i));
end To create 400 deployments, each with one pod. I opened both the deployments and the pods sections. No crashes occured, it loaded properly. |
The default value is set to 4Gb.
Fixes: #3925