Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal message to change stdout max buffer length preference... #4064

Conversation

vrubezhny
Copy link
Contributor

...in case of 'ERR_CHILD_PROCESS_STDIO_MAXBUFFER' error appearance

...in case of 'ERR_CHILD_PROCESS_STDIO_MAXBUFFER' error appearance

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 45.18%. Comparing base (da60441) to head (c2b6c00).
Report is 174 commits behind head on main.

Files Patch % Lines
src/cli.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4064       +/-   ##
===========================================
+ Coverage   32.37%   45.18%   +12.80%     
===========================================
  Files          85       85               
  Lines        6505     6717      +212     
  Branches     1349     1385       +36     
===========================================
+ Hits         2106     3035      +929     
+ Misses       4399     3682      -717     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny
Copy link
Contributor Author

A short demo of the proposal message for changing the preference value for the stdout max buffer length:

Screencast.from.2024-04-17.00-57-04.webm

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and is really helpful. Thanks, Victor!

@datho7561 datho7561 added the kind/enhancement New feature or request label Apr 17, 2024
@datho7561 datho7561 added this to the 1.14.0 milestone Apr 17, 2024
@datho7561 datho7561 merged commit 1b2fdf9 into redhat-developer:main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants