Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3906 implement port forward #4082

Conversation

msivasubramaniaan
Copy link
Collaborator

Fixes: #3906

image

image

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@datho7561
Copy link
Contributor

Please address JSDoc issues

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Thanks, Muthu! Please fix the JSDoc issues, after that this is good to merge.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 44.78%. Comparing base (da60441) to head (afba18e).
Report is 205 commits behind head on main.

Files Patch % Lines
src/port-forward.ts 31.20% 86 Missing ⚠️
src/explorer.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4082       +/-   ##
===========================================
+ Coverage   32.37%   44.78%   +12.41%     
===========================================
  Files          85       86        +1     
  Lines        6505     6935      +430     
  Branches     1349     1447       +98     
===========================================
+ Hits         2106     3106     +1000     
+ Misses       4399     3829      -570     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well. Thanks, Muthu!

@datho7561 datho7561 merged commit ed99af9 into redhat-developer:main May 6, 2024
4 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 3906-implement-port-forward-iu-addremoveshow-related-information branch May 7, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Port Forward UI (add/remove/show related information)
3 participants