Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in Helm Chart browser #4158

Merged

Conversation

datho7561
Copy link
Contributor

  • Fix bug where sometimes the charts don't load sometimes on Linux
  • Fix bug where view is stuck loading when there are no repos or charts
  • Clean up some of the code

Fixes #4083

Signed-off-by: David Thompson davthomp@redhat.com

@datho7561 datho7561 requested review from lgrossma and vrubezhny May 27, 2024 16:33
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 44.26%. Comparing base (da60441) to head (39d8a07).
Report is 250 commits behind head on main.

Files Patch % Lines
src/webview/helm-chart/helmChartLoader.ts 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4158       +/-   ##
===========================================
+ Coverage   32.37%   44.26%   +11.88%     
===========================================
  Files          85       90        +5     
  Lines        6505     7234      +729     
  Branches     1349     1525      +176     
===========================================
+ Hits         2106     3202     +1096     
+ Misses       4399     4032      -367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

- Fix bug where sometimes the charts don't load sometimes on Linux
- Fix bug where view is stuck loading when there are no repos or charts
- Clean up some of the code

Fixes redhat-developer#4083

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the fix-helm-chart-browser-bugs branch from 02af7c4 to 39d8a07 Compare May 27, 2024 17:52
@datho7561 datho7561 merged commit 9bad657 into redhat-developer:main May 27, 2024
3 of 4 checks passed
@datho7561 datho7561 deleted the fix-helm-chart-browser-bugs branch May 27, 2024 18:30
@rgrunber rgrunber mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart browser broken
3 participants