-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create serverless function view #4160
Fix create serverless function view #4160
Conversation
The root cause for this bug is the same as for the Helm Chart browser: we need confirmation from the webview that it's ready before we can start sending data to it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4160 +/- ##
===========================================
+ Coverage 32.37% 44.09% +11.72%
===========================================
Files 85 91 +6
Lines 6505 7291 +786
Branches 1349 1540 +191
===========================================
+ Hits 2106 3215 +1109
+ Misses 4399 4076 -323 ☔ View full report in Codecov by Sentry. |
- Split out the "invoke serverless function" webview from the "create serverless function" webview - For "create serverless function" and "invoke serverless function", wait on receiving a message from the webview before sending data to it - Fixing themeing in the "invoke serverless function" webview Fixes redhat-developer#4092 Signed-off-by: David Thompson <davthomp@redhat.com>
9d91c17
to
e030bef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Serverless Function Create and Invoke views work fine for me on Linux
Fixes #4092