Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create serverless function view #4160

Merged

Conversation

datho7561
Copy link
Contributor

@datho7561 datho7561 commented May 27, 2024

  • Split out the "invoke serverless function" webview from the "create serverless function" webview
  • For "create serverless function" and "invoke serverless function", wait on receiving a message from the webview before sending data to it
  • Fixing theming in the "invoke serverless function" webview

Fixes #4092

@datho7561
Copy link
Contributor Author

The root cause for this bug is the same as for the Helm Chart browser: we need confirmation from the webview that it's ready before we can start sending data to it.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 21.47651% with 117 lines in your changes are missing coverage. Please review.

Project coverage is 44.09%. Comparing base (da60441) to head (e030bef).
Report is 254 commits behind head on main.

Files Patch % Lines
...verless-function/invokeServerlessFunctionLoader.ts 22.36% 59 Missing ⚠️
...ew/serverless-function/serverlessFunctionLoader.ts 18.84% 56 Missing ⚠️
src/serverlessFunction/view.ts 50.00% 1 Missing ⚠️
src/webview/common-ext/utils.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4160       +/-   ##
===========================================
+ Coverage   32.37%   44.09%   +11.72%     
===========================================
  Files          85       91        +6     
  Lines        6505     7291      +786     
  Branches     1349     1540      +191     
===========================================
+ Hits         2106     3215     +1109     
+ Misses       4399     4076      -323     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Split out the "invoke serverless function" webview from the
  "create serverless function" webview
- For "create serverless function" and "invoke serverless function",
  wait on receiving a message from the webview before sending data to it
- Fixing themeing in the "invoke serverless function" webview

Fixes redhat-developer#4092

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the 4092-create-serverless-quay branch from 9d91c17 to e030bef Compare May 28, 2024 19:43
@datho7561 datho7561 changed the title [WIP] fix create serverless function view Fix create serverless function view May 28, 2024
@datho7561 datho7561 marked this pull request as ready for review May 28, 2024 19:45
Copy link
Collaborator

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Serverless Function Create and Invoke views work fine for me on Linux

@vrubezhny vrubezhny merged commit 264bd79 into redhat-developer:main May 29, 2024
3 of 4 checks passed
@datho7561 datho7561 deleted the 4092-create-serverless-quay branch May 29, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to create a serverless function using the Spring Boot template causes the webview to error
4 participants