-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Use ODO binary from nightly builds #4191
[build] Use ODO binary from nightly builds #4191
Conversation
In case we move to using ODO nightly builds, we do not need limiting the version of 'nodejs' devfile (or potentially of any other component devfiles), so we should close A workaround for 'ODO' stopped working after Devfile schema update to v.2.2.2 #4183 #4185 as not needed anymore |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4191 +/- ##
===========================================
+ Coverage 32.37% 43.89% +11.52%
===========================================
Files 85 95 +10
Lines 6505 7711 +1206
Branches 1349 1647 +298
===========================================
+ Hits 2106 3385 +1279
+ Misses 4399 4326 -73 ☔ View full report in Codecov by Sentry. |
c96e2cc
to
5dfb22b
Compare
1e90f1d
to
caa5664
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. If something breaks when it runs, we can always fix it or revert it. However, I'm also interested in Roland's review, since he's much more experienced in shell scripting than I am.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, though I haven't tested if it works in a fork yet.
caa5664
to
a7fd89f
Compare
a7fd89f
to
53536ef
Compare
@rgrunber I've changed the GH Action to download the ODO repository and calculate the nightly-versions as Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work. I just think some parts are a bit more complicated than they need to be.
53536ef
to
636a948
Compare
At the moment, the ODO Team looks like preparing a release for ODO v.3.16.0, so with or without this PR merged, we'll get that update. But for the future, we'll, probably, still need this PR - ODO Team has added commit numbers to the ODO download URLs - so since then we able to use nightly builds with no problem (as far as I understood, the archive and sha checksum files history is kept, so we can get sha checksum for an archive, download the archive later and check it against the saved sha checksum) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be working as far as generating the PR is conerned. Just found an issue regarding cmdFileName
.
636a948
to
374054d
Compare
374054d
to
2351738
Compare
eea693e
to
17d2609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working well for me so I would feel free to merge. Only thing I noticed is that because of github.event_name != 'schedule'
, this will go as far as update-odo
even though pr_exists
could have it terminate sooner. Is there a use-case for this ?
Otherwise, it seems fine to merge.
The goal is to make it run some steps even if we have no any new commits available in odo repository. But this looks like a check we don't really need as we don't rely on any cache hit/not hit-like event. |
17d2609
to
31cd822
Compare
Since the [ODO project](https://github.com/redhat-developer/odo) has stoped producing new releases for ODO binary, the [nightly builds](https://odo.dev/docs/overview/installation/#nightly-builds) became the source of most recent and up-to-date ODO binary version. Fixes: redhat-developer#4183 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
31cd822
to
c7084ed
Compare
Since the ODO project has stoped producing new releases for ODO binary, the nightly builds became the source of most recent and up-to-date ODO binary version.
Fixes: #4183