Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding wait for button to exist #4281

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

lgrossma
Copy link
Contributor

@lgrossma lgrossma commented Jul 12, 2024

See: #4129

Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.92%. Comparing base (da60441) to head (de9d49e).
Report is 357 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4281       +/-   ##
===========================================
+ Coverage   32.37%   43.92%   +11.55%     
===========================================
  Files          85       95       +10     
  Lines        6505     7699     +1194     
  Branches     1349     1647      +298     
===========================================
+ Hits         2106     3382     +1276     
+ Misses       4399     4317       -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgrossma
Copy link
Contributor Author

@vrubezhny This PR is response to your comments in #4129. It should provide some more stability, but even if I run the tests many times, I couldn't reproduce the fails you mentioned...

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@vrubezhny
Copy link
Contributor

vrubezhny commented Jul 12, 2024

@lgrossma Recently the builds/tests runs quite a lot more stably (especially Create Component tests)

From the problems I see sometimes is:

  • Slow refreshing of Components Tree (is to be fixed later)
  • Devfile Registry Editor items list is compared against the predefined test list of Devfile names BEFORE they actually appeared on the first search page, like in https://github.com/redhat-developer/vscode-openshift-tools/actions/runs/9814623145/job/27102500291 - ODO registry command returns all the required Devfiles, Registry Editor Search shows all 12 devfiles on the first page (when running manually), but test makes a try to check the Devfiles on the page BEFORE all of them are really shown on the first search page:
  1) Extension public-facing UI tests
       Devfile Registries
         open Devfile registry view from item's context menu and verify the content of the registry:

      AssertionError: expected [ 'Quarkus Java', '.NET 5.0', …(3) ] to be a superset of [ 'Quarkus Java', 'Django', …(7) ]
      + expected - actual

       [
         "Quarkus Java"
      -  ".NET 5.0"
      -  ".NET Core 3.1"
      -  "Universal Developer Image"
      -  "Vue"
      +  "Django"
      +  "Go Runtime"
      +  "Maven Java"
      +  "Node.js Runtime"
      +  "Open Liberty Gradle"
      +  "Open Liberty Maven"
      +  "Python"
      +  "Vert.x Java"
       ]
      
      at Context.<anonymous> (test/ui/suite/devfileRegistries.ts:129:70)
      at Generator.next (<anonymous>)
      at fulfilled (out/test/ui/suite/devfileRegistries.js:5:58)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

@vrubezhny vrubezhny merged commit e2e6002 into redhat-developer:main Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants