Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue opening Routes node in OpenShift explorer #4291

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Jul 16, 2024

When opening the Routes node of my DevSandbox cluster, I get this error:
Screenshot 2024-07-16 at 17 29 26

Screenshot 2024-07-16 at 17 35 57

This PR provides a naive fix for this issue, allowing my route to be displayed:

Screenshot 2024-07-16 at 17 44 09

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon
Copy link
Contributor Author

fbricon commented Jul 16, 2024

collectDeploymentErrors assumes the receiving object is a deployment. Naive fix => doesn't address route.status.ingress.conditions. Should it?

@vrubezhny
Copy link
Contributor

route.status.ingress.conditions

What do you mean? (Sorry, can't find anything like this in main)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.89%. Comparing base (da60441) to head (805ab3e).
Report is 369 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4291       +/-   ##
===========================================
+ Coverage   32.37%   43.89%   +11.52%     
===========================================
  Files          85       95       +10     
  Lines        6505     7716     +1211     
  Branches     1349     1635      +286     
===========================================
+ Hits         2106     3387     +1281     
+ Misses       4399     4329       -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny merged commit d3f0616 into redhat-developer:main Jul 16, 2024
4 checks passed
@vrubezhny vrubezhny added this to the 1.15.0 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants