Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commands to work with .yml extension #4357

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

branic
Copy link
Contributor

@branic branic commented Aug 12, 2024

This change allows the "Apply YAML to cluster" and "Delete YAML from clsuter" commands to accpet a file ending in .yml. Using a .yml extension name for YAML files is common and widely used so it makes sense to support both the .yaml and .yml naming.

src/yamlFileCommands.ts Outdated Show resolved Hide resolved
src/yamlFileCommands.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.86%. Comparing base (da60441) to head (862c5d2).
Report is 425 commits behind head on main.

Files Patch % Lines
src/yamlFileCommands.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4357       +/-   ##
===========================================
+ Coverage   32.37%   43.86%   +11.49%     
===========================================
  Files          85       95       +10     
  Lines        6505     7746     +1241     
  Branches     1349     1641      +292     
===========================================
+ Hits         2106     3398     +1292     
+ Misses       4399     4348       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@vrubezhny vrubezhny merged commit def78aa into redhat-developer:main Aug 13, 2024
4 checks passed
@vrubezhny vrubezhny added this to the 1.16.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants