Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added manual selection of builder image #4399

Conversation

msivasubramaniaan
Copy link
Collaborator

Ref: #4297

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan self-assigned this Aug 29, 2024
@msivasubramaniaan msivasubramaniaan linked an issue Aug 29, 2024 that may be closed by this pull request
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.

Project coverage is 43.58%. Comparing base (da60441) to head (de7fd50).
Report is 479 commits behind head on main.

Files with missing lines Patch % Lines
...ebview/create-deployment/createDeploymentLoader.ts 23.80% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4399       +/-   ##
===========================================
+ Coverage   32.37%   43.58%   +11.21%     
===========================================
  Files          85       98       +13     
  Lines        6505     7991     +1486     
  Branches     1349     1703      +354     
===========================================
+ Hits         2106     3483     +1377     
- Misses       4399     4508      +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datho7561
Copy link
Contributor

I've tried https://github.com/datho7561/bug-free-meme and https://github.com/datho7561/12345--painful--to---manage....git...repo...name , and analysis freezes at 35% for both.

In the console, I get :

TypeError: analyzeRes is not iterable
	at CreateDeploymentLoader.<anonymous> (vscode-file://vscode-app/home/davthomp/Documents/Projects/vscode-openshift-tools/out/src/webview/create-deployment/createDeploymentLoader.js:230:35)
	at Generator.next (<anonymous>)
	at fulfilled (vscode-file://vscode-app/home/davthomp/Documents/Projects/vscode-openshift-tools/out/src/webview/create-deployment/createDeploymentLoader.js:5:58)

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@datho7561
Copy link
Contributor

It seems like there are 12 possible images to pick from, yet the images/logos folder contains 101 logos. Is it possible to reduce the number of logos the application stores in order to reduce the extension size?

@datho7561
Copy link
Contributor

datho7561 commented Sep 3, 2024

I get the following when trying to analyse https://github.com/eclipse/lemminx:

TypeError: res.Aliases is not iterable (cannot read property null)

It freezes the UI at 35% complete

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is an issue with some parts of the logos being coloured purple, but I don't think there is an easy solution to that and I think fixing it can wait for later.

@msivasubramaniaan msivasubramaniaan merged commit 1b9d0e4 into redhat-developer:main Sep 3, 2024
4 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 4297-create-ui-for-select-different-builder-image branch September 3, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create UI for Select different builder image
3 participants