Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added additional clarification of terminal #4422

Merged

Conversation

msivasubramaniaan
Copy link
Collaborator

Ref: #3898

image

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan self-assigned this Sep 3, 2024
@msivasubramaniaan msivasubramaniaan linked an issue Sep 3, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (da60441) to head (40388a4).
Report is 480 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4422       +/-   ##
===========================================
+ Coverage   32.37%   43.53%   +11.16%     
===========================================
  Files          85       98       +13     
  Lines        6505     8014     +1509     
  Branches     1349     1705      +356     
===========================================
+ Hits         2106     3489     +1383     
- Misses       4399     4525      +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Muthu!

@vrubezhny vrubezhny merged commit b1925b2 into redhat-developer:main Sep 3, 2024
4 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 3898-no-terminals-opened branch September 3, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No terminals opened
4 participants