-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed ODO log command #4566
base: main
Are you sure you want to change the base?
removed ODO log command #4566
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4566 +/- ##
===========================================
+ Coverage 32.37% 43.85% +11.47%
===========================================
Files 85 99 +14
Lines 6505 8059 +1554
Branches 1349 1710 +361
===========================================
+ Hits 2106 3534 +1428
- Misses 4399 4525 +126 ☔ View full report in Codecov by Sentry. |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we don't use show&watch logs - shouldn't we remove the commands themselves here:
vscode-openshift-tools/src/odo/command.ts
Lines 49 to 61 in 3d7ccfc
static showLog(platform?: string): CommandText { | |
const result = new CommandText('odo', 'logs', [ | |
new CommandOption('--dev'), | |
]); | |
if (platform) { | |
result.addOption(new CommandOption('--platform', platform)); | |
} | |
return result; | |
} | |
static showLogAndFollow(platform?: string): CommandText { | |
return Command.showLog(platform).addOption(new CommandOption('--follow')); | |
} |
@vsCommand('openshift.component.log', true) | ||
static async log(componentFolder: ComponentWorkspaceFolder): Promise<void> { | ||
const componentName = componentFolder.component.devfileData.devfile.metadata.name; | ||
const showLogCmd = Command.showLog(Component.getDevPlatform(componentFolder)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we remove the command itself then?
@vsCommand('openshift.component.followLog', true) | ||
static async followLog(componentFolder: ComponentWorkspaceFolder): Promise<void> { | ||
const componentName = componentFolder.component.devfileData.devfile.metadata.name; | ||
const showLogCmd = Command.showLogAndFollow(Component.getDevPlatform(componentFolder)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Shouldn't we remove the command itself?
@@ -230,10 +230,6 @@ | |||
"onCommand:openshift.component.describe", | |||
"onCommand:openshift.component.openInBrowser", | |||
"onCommand:openshift.component.describe.palette", | |||
"onCommand:openshift.component.log", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrubezhny I removed the command as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Thanks, Muthu!
Ref: #4396
Removed
Show Log
andFollow Log
on the dropdown of component. We can useWatch Logs
onDeployments
andPods
in application explorer view.