removed ODO log command

[msivasubramaniaan]

Ref: #4396

Removed Show Log and Follow Log on the dropdown of component. We can use Watch Logs on Deployments and Pods in application explorer view.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.81%. Comparing base (da60441) to head (e704971).
Report is 607 commits behind head on main.

Files with missing lines	Patch %	Lines
src/explorer.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4566       +/-   ##
===========================================
+ Coverage   32.37%   43.81%   +11.44%     
===========================================
  Files          85       99       +14     
  Lines        6505     8052     +1547     
  Branches     1349     1709      +360     
===========================================
+ Hits         2106     3528     +1422     
- Misses       4399     4524      +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vrubezhny]

Once we don't use show&watch logs - shouldn't we remove the commands themselves here:

vscode-openshift-tools/src/odo/command.ts

Lines 49 to 61 in 3d7ccfc

	static showLog(platform?: string): CommandText {
	const result = new CommandText('odo', 'logs', [
	new CommandOption('--dev'),
	]);
	if (platform) {
	result.addOption(new CommandOption('--platform', platform));
	}
	return result;
	}
	static showLogAndFollow(platform?: string): CommandText {
	return Command.showLog(platform).addOption(new CommandOption('--follow'));
	}

?

[vrubezhny]

Shouldn't we remove the command itself then?

[vrubezhny]

Same here. Shouldn't we remove the command itself?

[msivasubramaniaan]

@vrubezhny I removed the command as well

[datho7561]

Seems good to me. Thanks, Muthu!

[vrubezhny]

@msivasubramaniaan Please take a look at #4566 (review) - I mean, you're removing all the "show/watch log"-like commands from palette/context menu/etc., but you're not removing the code in odo/command.ts that contains the methods that provide the implementations for these 'ODO` commands:

static showLog(platform?: string): CommandText {...}

static showLogAndFollow(platform?: string): CommandText {...}

... which look like aren't used anymore (after your PR is merged).

Do you want to keep these methods for any reason?

[msivasubramaniaan]

@msivasubramaniaan Please take a look at #4566 (review) - I mean, you're removing all the "show/watch log"-like commands from palette/context menu/etc., but you're not removing the code in odo/command.ts that contains the methods that provide the implementations for these 'ODO` commands:

static showLog(platform?: string): CommandText {...}

static showLogAndFollow(platform?: string): CommandText {...}

... which look like aren't used anymore (after your PR is merged).

Do you want to keep these methods for any reason?

@vrubezhny yes you were right. I removed those implementation as well. But I expect that compiler will show error/warning on the unused code. Need to add eslint rule to show error/warning on unused methods.

[lgrossma]

Is it necessary to delete these two tests entirely? If odo log gets replaced by different solution, these tests could be still used.. (Maybe some changes would be needed, but the workflow could stay the same)

[msivasubramaniaan]

As plan to get rid of ODO, I removed the whole code and these log functionality is working through oc logs. But not in the component level. It will be on deployment and pod level.

[lgrossma]

I still think it is pretty handy to be able to check the logs in component view and not having to look for the right deployment in the deployments view..

[vrubezhny]

Look good to me. Thanks!