Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.0.21] Adopt new K8s ext API to contribute openshift nodes to the tree #849

Merged
merged 1 commit into from
May 16, 2019

Conversation

dgolovin
Copy link
Collaborator

@dgolovin dgolovin commented May 16, 2019

Fix #852, #851.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #849 into 0.0.21 will decrease coverage by 1.77%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.0.21     #849      +/-   ##
==========================================
- Coverage   94.76%   92.98%   -1.78%     
==========================================
  Files          23       23              
  Lines        1376     1412      +36     
  Branches      222      233      +11     
==========================================
+ Hits         1304     1313       +9     
- Misses         72       99      +27
Impacted Files Coverage Δ
src/extension.ts 76.98% <30.76%> (-20.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95404ec...6c4a2fa. Read the comment docs.

@dgolovin dgolovin merged commit c4d6660 into redhat-developer:0.0.21 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant