Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from branch 0.0.21 to master #857

Merged
merged 5 commits into from
May 16, 2019
Merged

Merge changes from branch 0.0.21 to master #857

merged 5 commits into from
May 16, 2019

Conversation

dgolovin
Copy link
Collaborator

@dgolovin dgolovin commented May 16, 2019

Fix #853, #852, #851 in master.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #857 into master will decrease coverage by 1.91%.
The diff coverage is 29.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   94.77%   92.86%   -1.92%     
==========================================
  Files          23       23              
  Lines        1379     1612     +233     
  Branches      222      275      +53     
==========================================
+ Hits         1307     1497     +190     
- Misses         72      115      +43
Impacted Files Coverage Δ
src/extension.ts 75.78% <29.26%> (-22%) ⬇️
src/openshift/service.ts 100% <0%> (ø) ⬆️
src/openshift/catalog.ts 100% <0%> (ø) ⬆️
src/odo.ts 92.06% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe65d2e...fcaeed9. Read the comment docs.

@dgolovin dgolovin merged commit 4bd5957 into master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenShift clusters in K8s Clusters view should have OpenShift Icon
1 participant