Skip to content

Commit

Permalink
Adjust params, remove reason
Browse files Browse the repository at this point in the history
  • Loading branch information
sebrandon1 committed Oct 25, 2022
1 parent 61058c9 commit a28821c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cmd/check_container.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func resolveSubmitter(pc pyxisClient, cfg certification.Config) resultSubmitter
}
}

return newNoopSubmitter(true, "", nil)
return newNoopSubmitter(true, nil)
}

// getContainerPolicyExceptions will query Pyxis to determine if
Expand Down
2 changes: 1 addition & 1 deletion cmd/check_container_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ var _ = Describe("Check Container Command", func() {
bf = bytes.NewBuffer([]byte{})
bufferLogger.SetOutput(bf)

noop = newNoopSubmitter(false, "", bufferLogger)
noop = newNoopSubmitter(false, bufferLogger)
})

Context("and enabling log emitting", func() {
Expand Down
2 changes: 1 addition & 1 deletion cmd/check_operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func checkOperatorRunE(cmd *cobra.Command, args []string) error {
checkOperator.eng,
checkOperator.formatter,
checkOperator.rw,
newNoopSubmitter(false, "", nil), // we do not submit these results.
newNoopSubmitter(false, nil), // we do not submit these results.
)
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/preflight_check_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ var _ = Describe("Preflight Check Func", func() {

fmttr, _ = formatters.NewByName(formatters.DefaultFormat)
rw = &runtime.ResultWriterFile{}
rs = newNoopSubmitter(false, "", nil)
rs = newNoopSubmitter(false, nil)

DeferCleanup(os.RemoveAll, localTempDir)
DeferCleanup(os.RemoveAll, localArtifactsDir)
Expand Down
5 changes: 2 additions & 3 deletions cmd/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,15 +184,14 @@ type noopSubmitter struct {
log *log.Logger
}

func newNoopSubmitter(emitLog bool, reason string, log *log.Logger) *noopSubmitter {
func newNoopSubmitter(emitLog bool, log *log.Logger) *noopSubmitter {
return &noopSubmitter{
emitLog: emitLog,
reason: reason,
log: log,
}
}

var _ resultSubmitter = newNoopSubmitter(false, "", nil)
var _ resultSubmitter = newNoopSubmitter(false, nil)

func (s *noopSubmitter) Submit(ctx context.Context) error {
if s.emitLog {
Expand Down

0 comments on commit a28821c

Please sign in to comment.