Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Container Submission Flow to Better Handle Timeouts #709

Closed
acornett21 opened this issue Jun 24, 2022 · 2 comments · Fixed by #782
Closed

Enhance Container Submission Flow to Better Handle Timeouts #709

acornett21 opened this issue Jun 24, 2022 · 2 comments · Fixed by #782
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@acornett21
Copy link
Contributor

acornett21 commented Jun 24, 2022

Is your feature request related to a problem? Please describe.

When we first build check container we only had REST calls to pyxis in the submission flow, now that we have calls to pyxis in the checks, it leaves for a potential undesirable experience for partners. If there is a timeout in the checks, we then post an image with the certified: false for the image, and no way to change that, even if the partner re-runs preflight and gets valid results from pyxis on the 2nd, 3rd, nth run.

Describe the solution you'd like.

I'm not sure if the ideal solution is

  • If there is a pyxis timeout in the check, exit preflight/stop the submit call
  • Do a POST, GET, and if there is a diff do a PATCH for /images (see additional comments below)

Additional context.

PUT, PATCH was not available when we built preflight, and are not in the REST implementation yet, but were added in later see JIRA

@acornett21 acornett21 added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 24, 2022
@jfrancin
Copy link
Contributor

Another partner got bit by this same issue over the weekend. Case 03253477 - partner ran Preflight on three images; they all failed with a weird error:

time="2022-06-25T00:44:23-04:00" level=error msg="could not marshal GraphQL query: Message: Unexpected error occurred, Locations: []"
time="2022-06-25T00:44:23-04:00" level=error msg="Error when querying pyxis for uncompressed top layer idsMessage: Unexpected error occurred, Locations: []"
time="2022-06-25T00:44:23-04:00" level=error msg="Unable to verify layer hashesMessage: Unexpected error occurred, Locations: []"
time="2022-06-25T00:44:23-04:00" level=info msg="check completed: BasedOnUbi" ERROR="Message: Unexpected error occurred, Locations: []" result="Message: Unexpected error occurred, Locations: []"

Subsequent tests today (27 June) passed. Filed Jira https://issues.redhat.com/browse/ISVISSUE-149 to get results changed.

@jfrancin
Copy link
Contributor

Partner decided to rebuild (to cause different image SHAs), which allowed the containers to be re-submitted with passing grades, and are now published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants