Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a new updateImage method to enable partners to re-run #782

Merged
merged 1 commit into from
Sep 23, 2022
Merged

adding a new updateImage method to enable partners to re-run #782

merged 1 commit into from
Sep 23, 2022

Conversation

acornett21
Copy link
Contributor

  • Fixes: Enhance Container Submission Flow to Better Handle Timeouts #709
  • Adding an updateImage method that sets the certified value to true for a given architecture
  • Adding in login into the submit flow to call this value if the previous certified value we get when calling pyxis is false and the current execute's certified value is true
  • Added tests and updated mock data to support new flow

Signed-off-by: Adam D. Cornett adc@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@dcibot
Copy link

dcibot commented Sep 15, 2022

@acornett21 acornett21 mentioned this pull request Sep 15, 2022
Merged
@acornett21
Copy link
Contributor Author

/test 4.8-e2e

bcrochet
bcrochet reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits in comments and a question about the updateImage signature.

certification/pyxis/pyxis.go Outdated Show resolved Hide resolved
certification/pyxis/pyxis.go Outdated Show resolved Hide resolved
certification/pyxis/pyxis.go Outdated Show resolved Hide resolved
certification/pyxis/submit.go Outdated Show resolved Hide resolved
@dcibot
Copy link

dcibot commented Sep 19, 2022

@dcibot
Copy link

dcibot commented Sep 19, 2022

@komish
Copy link
Contributor

komish commented Sep 19, 2022

/test 4.8-e2e

komish
komish requested changes Sep 19, 2022
View reviewed changes
certification/pyxis/submit.go Outdated Show resolved Hide resolved
@dcibot
Copy link

dcibot commented Sep 19, 2022

komish
komish approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments have been address.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
bcrochet
bcrochet requested changes Sep 22, 2022
View reviewed changes
certification/pyxis/pyxis.go Outdated Show resolved Hide resolved
certification/pyxis/submit.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@dcibot
Copy link

dcibot commented Sep 22, 2022

@acornett21
adding a new updateImage method to enable partners to re-run prefligh…
43ac5c1 
…t if there are pyxis errors during our checks

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@dcibot
Copy link

dcibot commented Sep 23, 2022

bcrochet
bcrochet approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@komish
Copy link
Contributor

komish commented Sep 23, 2022

Still LGTM!

@bcrochet bcrochet merged commit 82aca79 into redhat-openshift-ecosystem:main Sep 23, 2022
@acornett21 acornett21 deleted the add_update_image branch September 23, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skattoju skattoju skattoju left review comments

@bcrochet bcrochet bcrochet approved these changes

@komish komish komish approved these changes

Assignees

@bcrochet bcrochet

@komish komish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Container Submission Flow to Better Handle Timeouts
5 participants
@acornett21 @dcibot @komish @bcrochet @skattoju