Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditionally calling pyxis.WithRPMManifest based on the policy value in ctx #1012

Merged
merged 1 commit into from
Jun 15, 2023
Merged

conditionally calling pyxis.WithRPMManifest based on the policy value in ctx #1012

merged 1 commit into from
Jun 15, 2023

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Jun 13, 2023 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@acornett21 acornett21 changed the title Using Context to Read rpm manifest file for policy exceptions conditionally calling pyxis.WithRPMManifest based on the policy value in ctx Jun 13, 2023
@dcibot
Copy link

dcibot commented Jun 13, 2023

@dcibot
Copy link

dcibot commented Jun 14, 2023

@dcibot
Copy link

dcibot commented Jun 14, 2023

@dcibot
Copy link

dcibot commented Jun 14, 2023

bcrochet
bcrochet requested changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Couple of requests

internal/lib/types.go Outdated Show resolved Hide resolved
internal/policy/policy.go Outdated Show resolved Hide resolved
@dcibot
Copy link

dcibot commented Jun 14, 2023

komish
komish reviewed Jun 15, 2023
View reviewed changes
internal/lib/types.go Outdated Show resolved Hide resolved
komish
komish reviewed Jun 15, 2023
View reviewed changes
internal/lib/types.go Outdated Show resolved Hide resolved
komish
komish approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@acornett21
conditionally calling pyxis.WithRPMManifest based on the policy that'…
8059497 
…s available in the context and excluding scatch policy from pyxis.WithRPMManifest

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@acornett21 acornett21 marked this pull request as ready for review June 15, 2023 15:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2023
@dcibot
Copy link

dcibot commented Jun 15, 2023

bcrochet
bcrochet approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 16f6229 into redhat-openshift-ecosystem:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@komish komish komish approved these changes

@yashoza19 yashoza19 Awaiting requested review from yashoza19

@tonytcampbell tonytcampbell Awaiting requested review from tonytcampbell

Assignees

@bcrochet bcrochet

@komish komish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preflight does not distinguish between scratch and non scratch when trying to read the RPM manifest from disc
4 participants
@acornett21 @dcibot @bcrochet @komish