Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling pyxis version check errors to display preflight release url #1141

Merged
merged 1 commit into from
May 13, 2024
Merged

handling pyxis version check errors to display preflight release url #1141

merged 1 commit into from
May 13, 2024

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Apr 10, 2024 •
edited
Loading

Sample Pyxis Responses:
Screenshot from 2024-03-12 12-39-13
Screenshot from 2024-03-12 12-38-52

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@dcibot
Copy link

dcibot commented Apr 10, 2024

from change #1141:

@acornett21
Copy link
Contributor Author

/test 4.15-e2e

@acornett21
Copy link
Contributor Author

/test 4.12-e2e

@acornett21
Copy link
Contributor Author

/test all

@acornett21 acornett21 marked this pull request as ready for review April 17, 2024 14:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
bcrochet
bcrochet requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions...

internal/pyxis/pyxis.go Outdated Show resolved Hide resolved
internal/pyxis/pyxis_suite_test.go Outdated Show resolved Hide resolved
internal/pyxis/pyxis_suite_test.go Outdated Show resolved Hide resolved
internal/pyxis/submit_test.go Outdated Show resolved Hide resolved
internal/pyxis/submit_test.go Outdated Show resolved Hide resolved
internal/pyxis/pyxis.go Outdated Show resolved Hide resolved
@acornett21 acornett21 force-pushed the log_version_check_error branch 2 times, most recently from 7aee214 to b9904a9 Compare April 17, 2024 15:28
bcrochet
bcrochet reviewed Apr 17, 2024
View reviewed changes
internal/pyxis/pyxis.go Outdated Show resolved Hide resolved
bcrochet
bcrochet reviewed Apr 17, 2024
View reviewed changes
internal/pyxis/pyxis.go Outdated Show resolved Hide resolved
@dcibot
Copy link

dcibot commented Apr 17, 2024

from change #1141:

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@acornett21
Copy link
Contributor Author

@komish @bcrochet I'm not really sure what to do with this PR. IMO using string(body) everywhere is the clearest path forward, since the intent of the type being used is in the code, trying to add another variable intrudes confusion of value/type of any given line of code that needs both the byte value and the string value.

@dcibot
Copy link

dcibot commented May 7, 2024

from change #1141:

bcrochet
bcrochet requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

internal/pyxis/pyxis.go Outdated Show resolved Hide resolved
@acornett21
handling pyxis version check errors to display preflight release url …
7362268 
…to user

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@dcibot
Copy link

dcibot commented May 8, 2024

from change #1141:

bcrochet
bcrochet approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
komish
komish approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 83ee11a into redhat-openshift-ecosystem:main May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@komish komish komish approved these changes

Assignees

@bcrochet bcrochet

@komish komish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acornett21 @dcibot @bcrochet @komish @openshift-merge-robot