Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding new release action to send release information to pyxis #1142

Merged
merged 1 commit into from
Apr 18, 2024
Merged

adding new release action to send release information to pyxis #1142

merged 1 commit into from
Apr 18, 2024

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Apr 15, 2024 •
edited
Loading

Info

  • Adding new workflow to send release information to pyxis.
    • This workflow does not get triggered on pre-releases (ie the checkbox on the release page). This will allow us to release a alpha/beta release that we can test in lower environments, but is not enabled/enforced by pyxis.

Tests

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@dcibot
Copy link

dcibot commented Apr 15, 2024

from change #1142:

@coveralls
Copy link

coveralls commented Apr 15, 2024 •
edited
Loading

Coverage Status

coverage: 81.752%. remained the same
when pulling ed18aa6 on acornett21:update_release_action
into 0670106 on redhat-openshift-ecosystem:main.

@acornett21 acornett21 force-pushed the update_release_action branch 2 times, most recently from 137d301 to ed18aa6 Compare April 15, 2024 22:46
@dcibot
Copy link

dcibot commented Apr 16, 2024

from change #1142:

komish
komish requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, couple of small things.

@dcibot
Copy link

dcibot commented Apr 16, 2024

from change #1142:

@acornett21 acornett21 force-pushed the update_release_action branch 4 times, most recently from 2c1d0db to 8ff61bf Compare April 16, 2024 20:54
@dcibot
Copy link

dcibot commented Apr 16, 2024

from change #1142:

@acornett21
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 16, 2024
@acornett21 acornett21 marked this pull request as ready for review April 16, 2024 22:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024
@acornett21
Copy link
Contributor Author

/test 4.15-e2e

@dcibot
Copy link

dcibot commented Apr 16, 2024

from change #1142:

@acornett21
Copy link
Contributor Author

/test 4.15-e2e

@acornett21
adding new release action to send release information to pyxis
5d9d2ad 
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@dcibot
Copy link

dcibot commented Apr 17, 2024

from change #1142:

komish
komish approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
skattoju
skattoju approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@skattoju skattoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, komish, skattoju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,komish,skattoju]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 4693c47 into redhat-openshift-ecosystem:main Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrhillsman mrhillsman mrhillsman left review comments

@lslebodn lslebodn lslebodn left review comments

@komish komish komish approved these changes

@skattoju skattoju skattoju approved these changes

@bcrochet bcrochet Awaiting requested review from bcrochet

@tonytcampbell tonytcampbell Awaiting requested review from tonytcampbell

Assignees

@komish komish

@skattoju skattoju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@acornett21 @dcibot @coveralls @komish @mrhillsman @lslebodn @skattoju