Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a call to controller-runtimes SetLogger and io.Discard #1160

Merged
merged 1 commit into from
May 8, 2024
Merged

adding a call to controller-runtimes SetLogger and io.Discard #1160

merged 1 commit into from
May 8, 2024

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 requested review from bcrochet and komish May 7, 2024 20:43
@openshift-ci openshift-ci bot requested review from jomkz and skattoju May 7, 2024 20:43
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@dcibot
Copy link

dcibot commented May 7, 2024

from change #1160:

bcrochet
bcrochet reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question.

cmd/preflight/cmd/root.go Outdated Show resolved Hide resolved
@komish
Copy link
Contributor

komish commented May 8, 2024

  1. Is this a result of a controller-runtime version bump, or have these log lines been there for a while?
  2. If this is new, should this not be a bug filed against controller-runtime?
  3. Should this be run closer to where the problem is? E.g. DeployableByOLM-related code?

@acornett21
Copy link
Contributor Author

  1. Is this a result of a controller-runtime version bump, or have these log lines been there for a while?
  2. If this is new, should this not be a bug filed against controller-runtime?
  3. Should this be run closer to where the problem is? E.g. DeployableByOLM-related code?
  1. This has been in controller-runtime since 0.15.0, and I've noticed it off/on since then, but since I'm usually running in trace I never understood why it would sometimes happen, and others not.
  2. No, this isn't a bug in controller runtime. It's just a warning to remind users of the library that 'hey you haven't called the logger'.
  3. I believe this is where this needs to be, since this is part of the init chain and only have 30seconds before the warning is thrown, at least that's how I read the code. Most other projects have this is root or main

@acornett21
adding a call to controller-runtimes SetLogger and io.Discard to avoi…
32da85a 
…d controller-runtimes noise in logging

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@dcibot
Copy link

dcibot commented May 8, 2024

from change #1160:

komish
komish approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
bcrochet
bcrochet approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bcrochet bcrochet merged commit 5fa97bf into redhat-openshift-ecosystem:main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@komish komish komish approved these changes

@jomkz jomkz Awaiting requested review from jomkz

@skattoju skattoju Awaiting requested review from skattoju

Assignees

@bcrochet bcrochet

@komish komish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate log.SetLogger for controller-runtime
4 participants
@acornett21 @dcibot @komish @bcrochet