update HasUniqueTag logic to fall back to the value the user provided #759
Conversation
openshift-ci
bot
added
the
approved
|
There might be a better way to throw errors in the tests, so if there is please let me know! Thanks! |
| if strings.HasPrefix(imgRef.ImageTagOrSha, "sha256:") { | ||
| tags, err = p.getDataToValidate(ctx, imgRepo) | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to get tags list for %s when sha256 provided: %v", imgRepo, err) |
There was a problem hiding this comment.
It looks like the only difference between these is just the log message. I don't think that necessarily adds any value. This can be reduced to a single if this || that.
There was a problem hiding this comment.
Along this line, to improve readability, I'd say that these two cases should be methods or functions. Then it literally becomes if this || that.
There was a problem hiding this comment.
This has been simplified, into one if statement.
|
Barring what Brad already said (I'm in agreement), this LGTM. /lgtm |
…, if they do not provide a sha, or a latest tag Signed-off-by: Adam D. Cornett <adc@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating the HashUniqueTag logic to follow the below rules:
The order above is so that the failover logic can be preserved for partners where we call the partners registry, and
/tags/listis available but they also returntagsas an empty list.Signed-off-by: Adam D. Cornett adc@redhat.com