Add static check for Check interface

[bcrochet]

Add a check in each of the checks to check for the check interface.

Signed-off-by: Brad P. Crochet brad@redhat.com

[coveralls]

Coverage remained the same at 84.283% when pulling 3300124 on bcrochet:check-interface-check into ee9cf5b on redhat-openshift-ecosystem:main.

[komish]

@bcrochet I'm not sure we need this.

We bind our checks to the CheckEngine which only accepts the Check interface, right? You get a compiler error without these assertions.

[dcibot]

• SUCCESS https://www.distributed-ci.io/jobs/e20d3124-b0d9-4682-8df1-fdfec5782399/jobStates
  from Add static check for Check interface #761

[bcrochet]

@bcrochet I'm not sure we need this.

We bind our checks to the CheckEngine which only accepts the Check interface, right? You get a compiler error without these assertions.

That is true. I was thinking though that until you actually do hook it up to the CheckEngine, it would be helpful to start with this assertion while developing a new check. I'm not super behind doing this, just thought it might be a nice to have. But if you think it's extra, I'm happy to just close this and move on.

[komish]

Good either way. We can be a little extra. 🎉

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment