Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin usage of operator-framework APIs #767

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Begin usage of operator-framework APIs #767

merged 1 commit into from
Aug 26, 2022

Conversation

bcrochet
Copy link
Contributor

The operator-framework API[1] has lots of bundle manipulation tools
that we can leverage to make our own code simpler. This begins the
journey of leveraging those APIs. This removes a good bit of code
that we get from the library.

[1] https://github.com/operator-framework/api

Signed-off-by: Brad P. Crochet brad@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@komish
Copy link
Contributor

komish commented Aug 22, 2022

@bcrochet sorry for the extra ping, but is this ready for review? I believe you may have mentioned something about this failing go test in standup, but I can't recall what it was.

@bcrochet
Copy link
Contributor Author

@bcrochet sorry for the extra ping, but is this ready for review? I believe you may have mentioned something about this failing go test in standup, but I can't recall what it was.

Waiting on this: operator-framework/api#255

@coveralls
Copy link

coveralls commented Aug 23, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 84.431% when pulling 64f7128 on bcrochet:validate-api into 5f4cc98 on redhat-openshift-ecosystem:main.

@dcibot
Copy link

dcibot commented Aug 23, 2022

@dcibot
Copy link

dcibot commented Aug 24, 2022

komish
komish requested changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things

certification/internal/bundle/bundle.go Outdated Show resolved Hide resolved
certification/internal/bundle/bundle.go Show resolved Hide resolved
certification/internal/policy/operator/deployable_by_olm.go Show resolved Hide resolved
certification/internal/policy/operator/validate_operator_bundle.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@bcrochet
Begin usage of operator-framework APIs
64f7128 
The operator-framework API[1] has lots of bundle manipulation tools
that we can leverage to make our own code simpler. This begins the
journey of leveraging those APIs. This removes a good bit of code
that we get from the library.

[1] https://github.com/operator-framework/api

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@dcibot
Copy link

dcibot commented Aug 26, 2022

komish
komish approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bcrochet bcrochet merged commit bd6549e into redhat-openshift-ecosystem:main Aug 26, 2022
@bcrochet bcrochet deleted the validate-api branch June 6, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@acornett21 acornett21 acornett21 approved these changes

Assignees

@komish komish

@acornett21 acornett21

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcrochet @komish @coveralls @dcibot @acornett21