Remove the project type when submitting updates to pyxis #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
komish
commented
Aug 18, 2022
Comment on lines
-102
to
+104
| Name string `json:"name"` // required | ||
| ProjectStatus string `json:"project_status"` // required | ||
| Type string `json:"type" default:"Containers"` // required | ||
| Name string `json:"name"` // required | ||
| ProjectStatus string `json:"project_status"` // required | ||
| Type string `json:"type,omitempty"` // required |
There was a problem hiding this comment.
A note to reviewers: These lines all changed because the comment's alignment changed.
bcrochet
reviewed
Aug 18, 2022
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
komish
force-pushed
the
fix-submit-patch
branch
from
a4926d2
to
9b62c34
Compare
bcrochet
reviewed
Aug 18, 2022
acornett21
approved these changes
Aug 18, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, komish, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
The issue listed above results from our CertProject struct, which contains the project type. Certain values for the project's type cannot be set via the external API, but our submission included them, resulting in a rejection from the API.
This patch adjusts the CertProject.Type key such that it uses omitempty, and on update calls, we zero out the value of CertProject.Type before we submit.
We'll want to cut a beta release after this merges, which can then be tested by the blocked partner.
Signed-off-by: Jose R. Gonzalez jose@flutes.dev