Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the bundle validate to use the API #770

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Switch the bundle validate to use the API #770

merged 1 commit into from
Sep 6, 2022

Conversation

bcrochet
Copy link
Contributor

This uses the validators directly, but still has the same usage
semantics, for the most part.

Signed-off-by: Brad P. Crochet brad@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@dcibot
Copy link

dcibot commented Aug 19, 2022

@bcrochet bcrochet added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 19, 2022
@bcrochet
Copy link
Contributor Author

Waiting on: operator-framework/api#255

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@dcibot
Copy link

dcibot commented Aug 23, 2022

@coveralls
Copy link

coveralls commented Aug 23, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 84.417% when pulling ffec18f on bcrochet:bundle-validate-api into bd6549e on redhat-openshift-ecosystem:main.

@dcibot
Copy link

dcibot commented Aug 23, 2022

@bcrochet bcrochet removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2022
@dcibot
Copy link

dcibot commented Aug 24, 2022

@bcrochet bcrochet force-pushed the bundle-validate-api branch 3 times, most recently from 052d0d0 to 4338934 Compare August 26, 2022 21:00
@dcibot
Copy link

dcibot commented Aug 26, 2022

@dcibot
Copy link

dcibot commented Aug 26, 2022

komish
komish reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. I think part of the challenge I have with this particular collection of checks is that the logic is feels somewhat tricky to follow. That's neither here nor there for this PR, though.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022
@bcrochet
Switch the bundle validate to use the API
3ce058c 
This uses the validators directly, but still has the same usage
semantics, for the most part.

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@dcibot
Copy link

dcibot commented Aug 30, 2022

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 5159bc1 into redhat-openshift-ecosystem:main Sep 6, 2022
@bcrochet bcrochet deleted the bundle-validate-api branch June 6, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@acornett21 acornett21 acornett21 approved these changes

@jomkz jomkz Awaiting requested review from jomkz

Assignees

@komish komish

@acornett21 acornett21

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcrochet @dcibot @coveralls @komish @acornett21