Fix some tests that would fail with existing env vars #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
bcrochet
force-pushed
the
fix-kubeconfig-test
branch
from
f096ffd
to
a016537
Compare
acornett21
approved these changes
Aug 22, 2022
komish
reviewed
Aug 22, 2022
certification/runtime/config_test.go
Outdated
| @@ -15,6 +16,10 @@ var _ = Describe("Viper to Runtime Config", func() { | |||
| baseViperCfg = viper.New() | |||
| expectedRuntimeCfg = &Config{} | |||
|
|
|||
| if val, ok := os.LookupEnv("KUBECONFIG"); ok { | |||
There was a problem hiding this comment.
NIT: good to merge without this change.
Suggested change
| if val, ok := os.LookupEnv("KUBECONFIG"); ok { | |
| if val, isSet := os.LookupEnv("KUBECONFIG"); isSet { |
There was a problem hiding this comment.
Happens in a couple of places, but because it's a nit, I'm only mentioning it here.
Some of the unit tests would fail if KUBECONFIG or PFLT_INDEXIMAGE were already present in the environment. This patch cleans those up a bit by checking for the existence, clearing them when required, and cleaning up appropriately after the test is run. This also includes minor renaming of some of the test suites, as they overlapped, and it was confusing where the error was actually coming from. Signed-off-by: Brad P. Crochet <brad@redhat.com>
bcrochet
force-pushed
the
fix-kubeconfig-test
branch
from
a016537
to
41725c6
Compare
skattoju
approved these changes
Aug 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the unit tests would fail if KUBECONFIG or PFLT_INDEXIMAGE
were already present in the environment. This patch cleans those up
a bit by checking for the existence, clearing them when required, and
cleaning up appropriately after the test is run.
This also includes minor renaming of some of the test suites, as they
overlapped, and it was confusing where the error was actually coming
from.
Signed-off-by: Brad P. Crochet brad@redhat.com