Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golangci lint #774

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Golangci lint #774

merged 2 commits into from
Aug 30, 2022

Conversation

bcrochet
Copy link
Contributor

Implement golangci-lint and update the codebase to adhere to the linter.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@dcibot
Copy link

dcibot commented Aug 23, 2022

acornett21
acornett21 reviewed Aug 23, 2022
View reviewed changes
.golangci.yaml Outdated Show resolved Hide resolved
@bcrochet bcrochet force-pushed the golangci-lint branch 3 times, most recently from 7772fb7 to f9d429c Compare August 24, 2022 12:32
@dcibot
Copy link

dcibot commented Aug 24, 2022

@coveralls
Copy link

coveralls commented Aug 24, 2022 •
edited
Loading

Coverage Status

coverage: 83.598% (-0.8%) from 84.435%
when pulling 4fcc7ac on bcrochet:golangci-lint
into bd6549e on redhat-openshift-ecosystem:main.

@dcibot
Copy link

dcibot commented Aug 24, 2022

@bcrochet bcrochet force-pushed the golangci-lint branch 2 times, most recently from 87ad9b3 to 8c592f1 Compare August 24, 2022 19:01
@dcibot
Copy link

dcibot commented Aug 24, 2022

@bcrochet
Copy link
Contributor Author

/test 4.8-e2e

@dcibot
Copy link

dcibot commented Aug 25, 2022

komish
komish requested changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things.

Spelling corrections are 👌

certification/formatters/formatters_test.go Outdated Show resolved Hide resolved
certification/internal/engine/engine.go Show resolved Hide resolved
certification/internal/operatorsdk/operatorsdk_test.go Show resolved Hide resolved
certification/internal/policy/container/base_on_ubi.go Show resolved Hide resolved
certification/internal/policy/operator/deployable_by_olm.go Outdated Show resolved Hide resolved
certification/internal/policy/operator/deployable_by_olm.go Outdated Show resolved Hide resolved
certification/internal/policy/operator/deployable_by_olm.go Show resolved Hide resolved
certification/pyxis/types.go Outdated Show resolved Hide resolved
acornett21
acornett21 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@acornett21 acornett21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinion one way or the other on any of the linter values chosen, or any of the changes. Since I am out next week, I'm going to approve this and will be happy to see some consistency in future PR's with whatever @bcrochet and @komish decide.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2022
@dcibot
Copy link

dcibot commented Aug 26, 2022

error in check dallas: unable to rebase PR 774 from redhat-openshift-ecosystem/openshift-preflight branch main

@bcrochet
Add golangci-lint to Makefile and actions
cd08897 
Create a 'make lint' target, and create an action that will run
golangci-lint on a PR and fail if it has any issues.

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2022
@dcibot
Copy link

dcibot commented Aug 27, 2022

komish
komish approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

for the most part I think the linter adds value. I've got the two open items I've mentioned but one is non-blocking and the other I believe we already discussed. To that end, I'll consider this approved.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@bcrochet
Implement changes suggested by golangci-lint
6c4b92a 
Signed-off-by: Brad P. Crochet <brad@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022
komish
komish approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @bcrochet

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcibot
Copy link

dcibot commented Aug 30, 2022

@bcrochet bcrochet merged commit ed82fca into redhat-openshift-ecosystem:main Aug 30, 2022
@bcrochet bcrochet deleted the golangci-lint branch June 6, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@acornett21 acornett21 acornett21 approved these changes

Assignees

@komish komish

@acornett21 acornett21

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bcrochet @dcibot @coveralls @komish @acornett21 @openshift-merge-robot