check container type for scratch exceptions instead of os_content_type #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
komish
added
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
|
Got confirmation that container.Type should be the field evaluated for scratch. This should be good for review. |
komish
removed
the
do-not-merge/hold
jomkz
approved these changes
Aug 29, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jomkz, komish, skattoju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to a recent review of data, we may be checking the wrong field to determine if a scratch exception is required. This corrects that.
Signed-off-by: Jose R. Gonzalez jose@flutes.dev